#115 | 'NEW' badge flag to inform about new version

changed tab creation method
alan-null · Jan 10, 2020 · f811a42 · f811a42
1 parent b186c0c
commit f811a42
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/app/chrome/popup/popup-new-version.html b/app/chrome/popup/popup-new-version.html
@@ -2,7 +2,6 @@
 <html>
 
 <body>
-	<a id="link" href="https://alan-null.github.io/redirect/sc-ext-update" target="_blank"></a>
 	<script src="scripts/popup-new-version.js"></script>
 </body>
 

diff --git a/app/chrome/popup/scripts/popup-new-version.ts b/app/chrome/popup/scripts/popup-new-version.ts
@@ -11,6 +11,6 @@ chrome.tabs.query({ currentWindow: true, active: true }, function (tabs) {
         sc_ext_setVersion_request: true,
         version: chrome.runtime.getManifest().version
     }, () => {
-        document.getElementById("link").click();
+        chrome.tabs.create({ url: "https://alan-null.github.io/redirect/sc-ext-update" });
     });
 });
diff --git a/app/chrome/popup/scripts/popup.ts b/app/chrome/popup/scripts/popup.ts
@@ -6,7 +6,7 @@
 'use strict';
 
 document.getElementById('go-to-options').addEventListener('click', function () {
-    window.open(chrome.runtime.getURL('options/options.html'));
+    chrome.tabs.create({ url: chrome.runtime.getURL("options/options.html") });
 });
 document.getElementById('version').textContent = "v." + chrome.runtime.getManifest().version;
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,6 @@ @@
     <html>
     <body>
-    	<a id="link" href="https://alan-null.github.io/redirect/sc-ext-update" target="_blank"></a>
     	<script src="scripts/popup-new-version.js"></script>
     </body>
@@ Expand Down @@