Fix url regex speed #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The url regex also leads to catastrophic backtracking for the file in #15, which causes a massive slowdown.
GjjvdBurg
added a commit
that referenced
this pull request
Jul 9, 2020
This was still using the old url regex, which was updated in #16. With this change filter_urls uses the same url regex as the one used for type detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on issue #13, but regarding the URL regex. The URL regex can similarly end up in catastrophic backtracking, and the proposed fix by @kaskawu can speed up detection significantly (as for example in the file mention in #15).
(this should've been addressed in #14)