Breaking change warnings during SHM deployment

[JimMadge]

💻 System information

• Operating System: Ubuntu Jammy
• Data Safe Haven version: f3fa833
• Powershell version: 7.2.5
• Az Powershell module version: 6.0.0
• Microsoft.Graph Powershell module version: 1.5.0
• Poshstache module version: 0.4.2

🍓 Desired behaviour

No warnings

🚫 Actual behaviour

Related to #1163.

A set of deprecation warnings

PS /home/vagrant/data_safe_haven/deployment/safe_haven_management_environment/setup> ./Setup_SHM_Nexus.ps1 -shmId testc -tier 2
...
WARNING: Upcoming breaking changes in the cmdlet 'Add-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
...
WARNING: Upcoming breaking changes in the cmdlet 'Set-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
...
WARNING: Upcoming breaking changes in the cmdlet 'Set-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.

PS /home/vagrant/data_safe_haven/deployment/safe_haven_management_environment/setup> ./Setup_SHM_Logging.ps1 -shmId testc
...
WARNING: Upcoming breaking changes in the cmdlet 'Get-AzOperationalInsightsWorkspaceSharedKey' :
Get-AzOperationalInsightsWorkspaceSharedKeys alias will be removed in an upcoming breaking change release
- The change is expected to take effect from the version : '2.0.0'
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
...
WARNING: Upcoming breaking changes in the cmdlet 'Get-AzOperationalInsightsIntelligencePack' :
Get-AzOperationalInsightsIntelligencePacks alias will be removed in an upcoming breaking change release
- The change is expected to take effect from the version : '2.0.0'
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.

PS /home/vagrant/data_safe_haven/deployment/safe_haven_management_environment/setup> ./Setup_SHM_Firewall.ps1 -shmId testc
...
WARNING: Upcoming breaking changes in the cmdlet 'New-AzPublicIpAddress' :
Default behaviour of Zone will be changed
Cmdlet invocation changes :
    Old Way : Sku = Standard means the Standard Public IP is zone-redundant.
    New Way : Sku = Standard and Zone = {} means the Standard Public IP has no zones. If you want to create a zone-redundant Public IP address, please specify all the zones in the region. For example, Zone = ['1', '2', '3'].
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
...
WARNING: Upcoming breaking changes in the cmdlet 'New-AzFirewall' :

- The parameter : 'VirtualNetworkName' is being replaced by parameter : 'VirtualNetwork'.
The type of the parameter is changing from 'System.String' to 'PSVirtualNetwork'.
- Change description : This parameter will be removed in an upcoming breaking change release. After this point the Virtual Network will be provided as an object instead of a string.
- The change is expected to take effect from the version : '2.0.0'
Cmdlet invocation changes :
    Old Way : New-AzFirewall -VirtualNetworkName "vnet-name"
    New Way : New-AzFirewall -VirtualNetwork $vnet

- The parameter : 'PublicIpName' is being replaced by parameter : 'PublicIpAddress'.
The type of the parameter is changing from 'System.String' to 'List<PSPublicIpAddress>'.
- Change description : This parameter will be removed in an upcoming breaking change release. After this point the Public IP Address will be provided as a list of one or more objects instead of a string.
- The change is expected to take effect from the version : '2.0.0'
Cmdlet invocation changes :
    Old Way : New-AzFirewall -PublicIpName "public-ip-name"
    New Way : New-AzFirewall -PublicIpAddress @($publicip1, $publicip2)
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
...
WARNING: Upcoming breaking changes in the cmdlet 'Set-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
WARNING: Upcoming breaking changes in the cmdlet 'Set-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.
WARNING: Upcoming breaking changes in the cmdlet 'Set-AzVirtualNetworkSubnetConfig' :
Update Property Name
Cmdlet invocation changes :
    Old Way : -ResourceId
    New Way : -NatGatewayId
Update Property Name
Cmdlet invocation changes :
    Old Way : -InputObject
    New Way : -NatGateway
Note : Go to https://aka.ms/azps-changewarnings for steps to suppress this breaking change warning, and other information on breaking changes in Azure PowerShell.

♻️ To reproduce

[jemrobinson]

These are annoying because:

• some of them refer to parameters we're not using and so aren't relevant to us
• the warnings can be suppressed but only on a global basis

[JimMadge]

That is irritating. It also isn't clear when the breaking change will happen.

[craddm]

The warnings that we can deal with were fixed in #1663; we cannot prevent others without turning all breaking change warnings off, since they relate to parameters/functions we don't use or have already corrected.