Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Set-AzDiagnosticSetting #1470

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

Set-AzDiagnosticSetting is deprecated for Az.Monitor >= 4.2.0. Here we update to the new syntax and update the required module version.

🌂 Related issues

Part of #1169.

🔬 Tests

Tested on a local SHM deployment

@JimMadge JimMadge merged commit 5d9c5b9 into alan-turing-institute:develop May 24, 2023
@jemrobinson jemrobinson mentioned this pull request Aug 14, 2023
5 tasks
@jemrobinson jemrobinson deleted the drop-deprecated-azure-command branch April 19, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants