Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate SRE name for non-pulumi commands #1879

Closed
JimMadge opened this issue May 10, 2024 · 1 comment · Fixed by #1921
Closed

Validate SRE name for non-pulumi commands #1879

JimMadge opened this issue May 10, 2024 · 1 comment · Fixed by #1921
Assignees
@JimMadge
Labels
bug Problem when deploying a Data Safe Haven.
Milestone
Release 5.0.0rc2

Comments

@JimMadge
Copy link
Member

The ProjectManager class ensures that user-provided names for SHMs and SREs are valid (they exist if they need to). There are functions which use SRE names without checking, for example user management commands.
@JimMadge JimMadge added this to the Release 5.1.0 milestone May 10, 2024
@JimMadge JimMadge mentioned this issue May 10, 2024
Merged
4 tasks
@jemrobinson jemrobinson added the bug Problem when deploying a Data Safe Haven. label May 17, 2024
@JimMadge
Copy link
Member Author

Having a look at this,

  • Some commands will create an instance of DSHProjectManager so will have the same validation as sre/shm commands. (In particular, those that use GuacamoleUsers).
  • Others just use the Azure API and might need extra checks.

@JimMadge JimMadge mentioned this issue May 30, 2024
Merged
3 tasks
@JimMadge JimMadge self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimMadge JimMadge

Labels
bug Problem when deploying a Data Safe Haven.
Projects
None yet
Milestone
Release 5.0.0rc2
Development

Successfully merging a pull request may close this issue.

Validate SHM/SRE for user commands alan-turing-institute/data-safe-haven
2 participants
@jemrobinson @JimMadge