Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate SHM/SRE for user commands #1921

Merged
merged 5 commits into from
May 30, 2024
Merged

Validate SHM/SRE for user commands #1921

merged 5 commits into from
May 30, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Add checks that Pulumi configuration for SHM/SREs exists.
This is a proxy for ensuring the infrastructure exists.
It should be more reliable that just checking if the names are used in the DSH configuration, and much lighter weight than checking for particular pieces of infrastructure (either using Azure API or looking through the Pulumi stack).

🌂 Related issues

Closes #1879

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner May 30, 2024 09:44
Copy link

github-actions bot commented May 30, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  users.py 124, 142, 226, 244
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 675e063 into develop May 30, 2024
11 checks passed
@JimMadge JimMadge deleted the validate_sre branch May 30, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate SRE name for non-pulumi commands
2 participants