-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Powershell module requirements #1368
Update Powershell module requirements #1368
Conversation
May have discovered another related issue, switching to draft while I double-check |
When it comes to the powershell version, I think we should try to only support one of
It really doesn't make sense to support unmaintained powershell versions and the more we try to support the more difficult it will be to find a set of working module versions. |
Ok, so in practical terms does this mean increasing the minimum Powershell version in |
It's worth saying that we only support latest stable and latest LTS without directly enforcing in the code. It does look like we could check for >=7.2.9 in the code though? |
We should be clear in the documentation. Having a warning in
I get the impression that trying to support both is causing problems, particularly with the large number of modules. I think it might be better to choose just one. |
Ok, so will add an additional check in As far as I can tell the modules that are compatible with 7.3.0+ are also compatible with 7.2.9 etc., just not the other way round. But it'll definitely be easier to commit to a specific supported version. |
Maybe we can/should drop the whole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
but it may have changed since then)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
.Updates several required Powershell module versions to be compatible with more recent versions (7.3.x) of Powershell (see #1332). The updated modules are also still compatible with several Powershell versions after testing (7.2.8, 7.2.9).
CheckRequirements.ps1
now warns the user if they are using an unsupported Powershell version, with the supported version being the latest stable version (currently 7.3.2). Also fixes retrieval of Powershell version numbers, which were incorrectly retrieved in some circumstances.Adds an additional module to
CheckRequirements.ps1
-Microsoft.Graph.Users
. Some functions from this module are used when deploying an SHM.Updates the .devcontainer to use Powershell 7.3.2.
Updates the documents to suggest users use the supported Powershell version.
🌂 Related issues
Closes #1361
Closes #1369
Closes #1373
🔬 Tests
Ran several (SRE and SHM) deployment steps that were failing on Powershell versions 7.3.x with updated module versions to confirm that the updated versions fixed the issues (see #1332). Also ran the same steps on versions 7.2.6, 7.2.8, and 7.2.9 to check that the updated modules were compatible.