Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Badges #1371

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Update Badges #1371

merged 2 commits into from
Feb 1, 2023

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Feb 1, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

  • Remove Travis CI badge
  • Add GitHub workflow badges for linting and tests
  • Add citation badge directing to CITATION.cff

🌂 Related issues

🔬 Tests

Preview README.md on this branch.

Copy link
Contributor

@edwardchalstrey1 edwardchalstrey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the Lint code badge appears to show as failing on this branch even though the actions doesn't have it failing?

@JimMadge
Copy link
Member Author

JimMadge commented Feb 1, 2023

I think that is because it is getting the state from the default branch (which has failed a html external link check).

@JimMadge
Copy link
Member Author

JimMadge commented Feb 1, 2023

Re-ran the tests and it is all passing now 👍

@JimMadge JimMadge merged commit aef639f into develop Feb 1, 2023
@JimMadge JimMadge deleted the badges branch February 1, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants