Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi: Fix user list retrieval #1386

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Feb 6, 2023

⤴️ Summary

Fixes Powershell script list_users.ps1 so that querying the user list correctly returns users from the domain controller, allowing them to be added to SREs etc.

Also adds domain controller password to backend vault

🌂 Related issues

Closes #1385
Also closes #1384

@craddm craddm changed the title Pulumi: Fix Pulumi: Fix user list retrieval Feb 6, 2023
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craddm craddm merged commit 92403c5 into alan-turing-institute:python-migration Feb 7, 2023
@jemrobinson jemrobinson added this to the Python migration milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants