Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow CRAN package to Tier 3 allowlist #1391

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Feb 21, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

Adds the arrow package to the extra and full allowlists for Tier 3 packages. All required dependencies are already on the full list.

🌂 Related issues

Closes #1388

🔬 Tests

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jemrobinson jemrobinson merged commit 2d5ce74 into alan-turing-institute:develop Feb 22, 2023
@craddm craddm deleted the allowlist-arrow branch May 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Arrow (R package) to be added to the Tier 3 approve list - and working in tier 3 SRE
3 participants