-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove egress steps not carried out by System Manager #1434
Remove egress steps not carried out by System Manager #1434
Conversation
I think this section of documentation is a bit poor and confusing in general.
I have made some changes and pushed them to this branch. Could you add those to your fork's branch and push them so they are part of the PR or allow edits? |
|
@JimMadge I was able to sync your edits |
Hmm, yes it works. Not sure what I was doing wrong before 🤦 |
These will 403 as a user needs to be logged into GitHub to edit files.
I'm not worried about the remaining link checking errors. The website exists and the check is probably failing due to rate limiting. @edwardchalstrey1 and @harisood can you build and read the documentation for a sanity check? I think it is quite poor in the current state (see my comment above). |
Updated
Do we want to say this in the DSH docs? I'm thinking that we document our own processes for the Turing prod DSH for this, but for the open source software is it not up to whoever uses it to figure this out? |
Thanks @edwardchalstrey1 I missed that reference.
I'm pretty certain that we do. It isn't a discussion of the Turing's (or any organisations) particular process. It is just stating that outputs need to be reviewed. I don't think you can have a functional TRE if you can remove data without review. This is also consistent with how the data ingress steps are described. |
Agreed, just realised you have added this already @JimMadge I'm happy with this now, but let me know if you think further edits needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
but it may have changed since then)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
.The second part of this section is instructions for the egress-ee, not the System Manager - I'm removing this to avoid confusion. I will also update Turing internal documentation to have the information that is removed here, making egress documented in the same way as ingress.
🌂 Related issues
Closes #1420
Tandem PR on Turing docs: https://github.com/alan-turing-institute/trusted-research/pull/156
🔬 Tests