Better package name matching for Nexus #1447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
but it may have changed since then)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
.Modifies how the
configure_nexus.py
script creates Nexus Content Selector search patterns, allowing CRAN packages to include capital letters and following the complete package name with_
(e.g.RPostgreSQL_
) to prevent overly permissive matching and installation of non-allow-listed packages.Note that to perform the fix I had to teardown the existing proxy VM and redeploy it. The issues cannot be fixed by modifying the local copy of the
configure_nexus.py
script, as the important copy is on the docker container running Nexus on the VM. It's not clear to me how to modify that without redeploying the VM entirely (but it may be clear to someone else!).🌂 Related issues
Closes #1445
Closes #1439
🔬 Tests
Packages with capital letters can now be installed correctly on Tier 3 VMs:
Packages that are not on the allowlist but that had names that would still match search patterns for other packages (e.g.
csvread
, which matched the pattern forcsv
) can no longer be installed and will correctly return a403 Forbidden
code: