Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pdf and html downloads on readthedocs #1462

Merged
merged 3 commits into from
May 24, 2023
Merged

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

  • PDF and archived html docs are build and can be downloaded from readthedocs.io
  • Remove exact version requirements from requirements.in
  • Update requirements.txt

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested review from jemrobinson and craddm May 16, 2023 09:44
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I mildly prefer pinned requirements for reproducibility and ease of knowing when changes are made. Is there a reason this was removed or is requirements.in just the input for the final requirements.txt?

@JimMadge
Copy link
Member Author

requirements question explained here: #1476 (comment)

@JimMadge JimMadge merged commit ce20273 into develop May 24, 2023
@JimMadge JimMadge deleted the readthedocs_downloads branch May 24, 2023 09:12
@jemrobinson jemrobinson mentioned this pull request Aug 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants