Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of how to change allowed inbound IP addresses #1484

Merged
merged 13 commits into from
Aug 7, 2023

Conversation

craddm
Copy link
Contributor

@craddm craddm commented May 30, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

Adds some explanatory text to the Manage Users section. Question is, is this the right place for the instructions?

🌂 Related issues

Closes #1444

🔬 Tests

Built the documents locally.

@JimMadge
Copy link
Member

@craddm Are you still working on this?

@craddm craddm changed the title [WIP] Add explanation of how to change allowed inbound IP addresses Add explanation of how to change allowed inbound IP addresses Aug 3, 2023
@craddm craddm marked this pull request as ready for review August 3, 2023 14:03
@craddm
Copy link
Contributor Author

craddm commented Aug 3, 2023

@JimMadge I was trying to think of whether there was a better place for the instructions, but I don't think there is, or that it's worth adding another section

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think it can fit in this section if we phrase it as "Enabling users to connect from approved locations" rather than "modifying network rules".

docs/source/roles/system_manager/manage_users.md Outdated Show resolved Hide resolved
docs/source/roles/system_manager/manage_users.md Outdated Show resolved Hide resolved
docs/source/roles/system_manager/manage_users.md Outdated Show resolved Hide resolved
docs/source/roles/system_manager/manage_users.md Outdated Show resolved Hide resolved
docs/source/roles/system_manager/manage_users.md Outdated Show resolved Hide resolved
Co-authored-by: Jim Madge <jim+github@jmadge.com>
@edwardchalstrey1
Copy link
Contributor

LGTM

craddm and others added 3 commits August 4, 2023 12:30
@jemrobinson jemrobinson merged commit e7b5828 into alan-turing-institute:develop Aug 7, 2023
@craddm craddm deleted the inbound-docs branch August 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to add a new inboundAccessFrom IP address
4 participants