Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin container images #1501

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Pin container images #1501

merged 5 commits into from
Jun 29, 2023

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Pin unpinned container image version. In particular nexus-allowlist which was using the 'main' tag that could point to unstable/broken builds.

This is also consistent with other container instance specifications in the project.

I think there is a discussion around what level to pin to. I have tried to pin to major versions where possible as this a avoids known, breaking changes being introduced.
Pinning to minor or patch versions gives more confidence that there will be no regressions, however it adds more burden to update versions more regularly.

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested a review from jemrobinson June 29, 2023 08:56
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit a216475 into python-migration Jun 29, 2023
@jemrobinson jemrobinson deleted the pin_container_images branch June 29, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants