-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor config files #1510
Refactor config files #1510
Conversation
…l work directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I think this config structure makes more sense. Using dataclasses is sensible and will help with validation. (We could use something like pydantic, but I think that is overkill unless you have many dataclass-type classes).
It looks like this has enabled other places of the code to be tidied too.
…r followed by 0 or 1 digits then 0 or more lowercase letters)
5c80469
to
d2705b1
Compare
30fdc09
to
f8c96e2
Compare
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).external.api
andexternal.interface
intoexternal
(unnecessary nesting)PulumiStack
intoPulumiSHMStack
andPulumiSREStack
(better than changing behaviour with strings)DotFileSettings
with better namedBackendSettings
BackendSettings
inappdirs
config path instead of local directoryBackendSettings
to only be updated ininit
and read duringConfig
constructionConfig
from adotmap
to a nested set of dataclasses (allows type-hinting to work correctly)🌂 Related issues
Closes #1509
Check #1506 before merging
🔬 Tests
Tested locally