-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pip-compile for package resolution #1514
Conversation
@edwardchalstrey1: Can you try a build from this branch and see whether everything works for you? By replacing poetry with pip-compile we should avoid the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think the long term solution is to remove these altogether. It is a pain to support and we have a better way of installing Python packages for most Tiers.
It might be more idiomatic if the unpinned requirements are in a file called requirements.in
and the output of pip-compile
is called requirements.txt
. However, that is not a hill to die on.
7493159
to
b176e94
Compare
Agreed - I just wanted to make the most minimal change in this PR. |
Deploying a new candidate VM from this branch now. Will let you know the results |
Success:
|
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).poetry
withpip-compile
for Python package resolution🌂 Related issues
Closes #1493
🔬 Tests
Tested locally, but could do with independent testing.