Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Enum for ports #1819

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Create Enum for ports #1819

merged 5 commits into from
Apr 19, 2024

Conversation

JimMadge
Copy link
Member

⤴️ Summary

  • Create Enum to enumerate ports used
  • Replace strings with Enum

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner April 17, 2024 10:19
@JimMadge JimMadge added this to the Release 5.0.0rc2 milestone Apr 17, 2024
jemrobinson
jemrobinson approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jemrobinson
jemrobinson requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed.

@jemrobinson jemrobinson merged commit 6fb6aa2 into develop Apr 19, 2024
10 checks passed
@jemrobinson jemrobinson deleted the ports_enum branch April 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemrobinson jemrobinson jemrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 5.0.0rc2
Development

Successfully merging this pull request may close these issues.
2 participants
@JimMadge @jemrobinson