-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move update servers to SRE #1847
Merged
jemrobinson
merged 28 commits into
alan-turing-institute:develop
from
jemrobinson:1837-move-update-servers-to-sre
May 3, 2024
Merged
Move update servers to SRE #1847
jemrobinson
merged 28 commits into
alan-turing-institute:develop
from
jemrobinson:1837-move-update-servers-to-sre
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional Linux VMs beyond the workspaces
…s a subset to be selected
… constructing it.
jemrobinson
force-pushed
the
1837-move-update-servers-to-sre
branch
from
April 30, 2024 13:46
38e23c6
to
e943b8b
Compare
Would it be sensible to merge #1820 into this? |
I think they're independent. Is #1820 ready to merge? |
I think there will be some conflicts (hopefully easy to fix 🤞). |
I suggest we do the following:
|
jemrobinson
force-pushed
the
1837-move-update-servers-to-sre
branch
from
May 2, 2024 11:55
ca3356a
to
2465b0f
Compare
craddm
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge).Note that the workspaces must be deployed after the apt-proxy is fully configured. To achieve this we make the workspace dependent on the apt-proxy private DNS hostname, which itself is dependent on the apt-proxy private IP address which is not available until the container reaches "Running" status.
🌂 Related issues
Closes #1837. Closes #1832.
🔬 Tests
Tested on fresh SHM and SRE deployment