-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge SHM and context resource deployment #1963
Merge SHM and context resource deployment #1963
Conversation
…guments to 'dsh deploy shm'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I have some questions, and there are a few pieces I'm not very keen on.
I think there is scope to improve the coverage in data_safe_haven/commands/
and data_safe_haven/config/
.
Co-authored-by: Jim Madge <jim+github@jmadge.com>
Co-authored-by: Jim Madge <jim+github@jmadge.com>
0e71103
to
1d0524c
Compare
@craddm Would appreciate your thoughts on the conversations here. |
b4d1796
to
c12091d
Compare
@JimMadge : Anything else you want to see here? |
62e6884
to
7d359a0
Compare
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
n/a
This PR moves SHM deployment out of Pulumi and into AzureSDK commands. It also refactors the CLI interface so only the following commands are needed to deploy and SHM and SREs
It moves some config values between
Context
andSHMConfig
so that fewer things depend on the (local-only)Context
and more things use the (shared)SHMConfig
. The things remaining inContext
are all human-readable (no GUIDs)Config examples
🌂 Related issues
Closes #1850
Closes #1896
Closes #1898
Closes #1900
Closes #1962
Closes #1965
🔬 Tests
Tested locally