Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #1970

Merged

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Jun 27, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

  • Remove unused ConfigSection::update() functions
  • Remove unused ConfigName validation and tests
  • Add tests for ConfigSection and SafeString
  • Simplify dsh sre deploy/teardown logic
  • BUGFIX: create DSHPulumiConfig in sre deploy or this will not be done

🌂 Related issues

n/a

🔬 Tests

Tested locally

@jemrobinson jemrobinson requested a review from a team as a code owner June 27, 2024 14:45
@jemrobinson jemrobinson requested review from craddm, JimMadge and a team June 27, 2024 14:47
Copy link

github-actions bot commented Jun 27, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/administration/users
  guacamole_users.py 45
  data_safe_haven/commands
  sre.py 53-56, 96-100, 137-147
  users.py 160
  data_safe_haven/config
  config_sections.py
  sre_config.py
  data_safe_haven/external/api
  azure_api.py
  data_safe_haven/infrastructure/programs
  declarative_sre.py
  data_safe_haven/types
  annotated_types.py
  data_safe_haven/validators
  validators.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Clears out a lot of code we don't need 🎉.

data_safe_haven/commands/sre.py Show resolved Hide resolved
data_safe_haven/commands/sre.py Show resolved Hide resolved
tests/config/test_config_sections.py Outdated Show resolved Hide resolved
@jemrobinson jemrobinson merged commit a7f9b0c into alan-turing-institute:develop Jun 28, 2024
11 checks passed
@jemrobinson jemrobinson deleted the remove-update-sections branch January 30, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants