Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'force' option to SRE teardown #1982

Merged

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

  • Adds --force option to SRE teardown
  • Adds tests for dsh sre X commands

🌂 Related issues

Closes #1932

🔬 Tests

Not tested

@jemrobinson jemrobinson requested a review from a team as a code owner July 3, 2024 06:56
@jemrobinson jemrobinson requested a review from a team July 3, 2024 06:56
@jemrobinson jemrobinson force-pushed the 1932-add-teardown-force branch from e5d1cca to d0f8ae6 Compare July 3, 2024 06:59
Copy link

github-actions bot commented Jul 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  sre.py
  data_safe_haven/infrastructure
  project_manager.py 283-286, 361-362
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One suggestion for further work or a new issue.

tests/commands/test_sre.py Show resolved Hide resolved
@jemrobinson jemrobinson merged commit 670e58a into alan-turing-institute:develop Jul 3, 2024
11 checks passed
@jemrobinson jemrobinson deleted the 1932-add-teardown-force branch January 30, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot teardown when pulumi action in progress
2 participants