Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DockerHub credentials #2007

Merged

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Use DockerHub credential from SREConfig to pull images from dockerhub.

🌂 Related issues

Closes #1984

🔬 Tests

Tested on a fresh SRE deployment

@jemrobinson jemrobinson requested a review from a team as a code owner July 9, 2024 19:56
@jemrobinson jemrobinson force-pushed the 1984-dockerhub-credentials branch from 2981b51 to a0cb714 Compare July 11, 2024 10:05
@jemrobinson jemrobinson requested a review from a team July 11, 2024 10:05
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/config
  config_sections.py
  sre_config.py
  data_safe_haven/infrastructure/common
  __init__.py
  dockerhub_credentials.py
  data_safe_haven/infrastructure/programs
  declarative_sre.py 80
  data_safe_haven/infrastructure/programs/sre
  dns_server.py 36
  gitea_server.py 55
  hedgedoc_server.py 57
  identity.py 43
  remote_desktop.py 65
  software_repositories.py 44
  user_services.py 55
  data_safe_haven/validators
  validators.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jemrobinson jemrobinson merged commit cfd6aaf into alan-turing-institute:develop Jul 11, 2024
11 checks passed
@jemrobinson jemrobinson deleted the 1984-dockerhub-credentials branch July 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy Azure Container Instances from Docker
2 participants