Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude doi.org from lychee link check #2030

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Exclude doi.org from lychee link check #2030

merged 1 commit into from
Jul 22, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner July 22, 2024 08:50
jemrobinson
jemrobinson approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this apply to 4.X.Y too?

@JimMadge JimMadge merged commit fef670c into develop Jul 22, 2024
11 checks passed
@JimMadge JimMadge deleted the lychee_doi branch July 22, 2024 08:54
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemrobinson jemrobinson jemrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimMadge @jemrobinson