Stop unnecessary resource recreation

[jemrobinson]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

• Exclude self.auth_token from the diff when deciding whether a new EntraApplication is needed.
• Exclude start_date_time when deciding whether a new MaintenanceConfiguration is needed

🌂 Related issues

Closes #2028

🔬 Tests

Testing in progress.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/components/dynamic
entra_application.py					121
Project Total

This report was generated by python-coverage-comment-action

[JimMadge]

LGTM.

I think it is fine to exclude the __provider and take the consequences of that as known limitations.

Might want to open an issue to document that?

[jemrobinson]

I think the limitations are pretty minor. If we change the class signature (e.g. by adding a new method or attribute) then this won't trigger a redeploy of the Entra Application. However, if we've got a working Application, it's unlikely that we want a change to the Provider class to trigger a redeploy anyway. This is documented in the comment which I think is actually more useful than an issue in this case.