Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teardown --force #2060

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Ensure that we cancel as the first step of teardown since ongoing operations will prevent the refresh from occurring

🌂 Related issues

n/a

🔬 Tests

Tested on a teardown

…perations will prevent the refresh from occurring
@jemrobinson jemrobinson requested a review from a team as a code owner July 29, 2024 10:06
@jemrobinson jemrobinson requested review from a team, craddm and JimMadge July 29, 2024 10:06
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/infrastructure
  project_manager.py 382
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit 8a63055 into alan-turing-institute:develop Jul 29, 2024
11 checks passed
@jemrobinson jemrobinson deleted the fix-teardown branch January 30, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants