Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notify to non-existent handler #2122

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Remove notify to non-existent handler #2122

merged 1 commit into from
Aug 12, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

Closes #2120

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner August 12, 2024 13:15
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we're sure we don't need this handler

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@JimMadge
Copy link
Member Author

LGTM as long as we're sure we don't need this handler

Yes I'm fairly certain. I think it was trying to do the same as adding the pam_mkhomedir.so mnodule. It didn't add any rules that we didn't already have.
I think before the cloud-init used a mixture of editing pam.d files and using the command line tool.
Now we can use the Ansible module.

@JimMadge JimMadge merged commit 17a7090 into release-v5.0.0 Aug 12, 2024
11 checks passed
@JimMadge JimMadge deleted the pam_handler branch August 12, 2024 13:23
@jemrobinson jemrobinson mentioned this pull request Aug 28, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants