Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable light locker #2126

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Disable light locker #2126

merged 1 commit into from
Aug 14, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Aug 13, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

Closes #2101

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner August 13, 2024 14:25
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@JimMadge
Copy link
Member Author

JimMadge commented Aug 14, 2024

The file has been written correctly.

jim.madge:~$ cat /etc/xdg/autostart/light-locker.desktop 
Hidden=true 

@JimMadge
Copy link
Member Author

I tested the lock screen and it seems to be working,

  • I closed my Guacamole tab
  • Opened a new tab and connected to the workspace
  • I was prompted for a username and password by the xrdp login
  • Went straight back to my desktop session, no need to unlock

@JimMadge JimMadge requested a review from jemrobinson August 14, 2024 08:48
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit bbff641 into release-v5.0.0 Aug 14, 2024
11 checks passed
@JimMadge JimMadge deleted the light_locker branch August 14, 2024 09:00
@JimMadge
Copy link
Member Author

Actually, this might not be right. The screen still locks after idling for some time.

@JimMadge
Copy link
Member Author

JimMadge commented Aug 14, 2024

Possibly because the file is missing the [Desktop Entry] group header

@jemrobinson
Copy link
Member

Or it could be that we're using a different lock screen programme - note that the previous instructions were for XFCE3. I think there's now an xfce4-screenlocker.

@JimMadge
Copy link
Member Author

Hmm, that might be right, light-locker isn't installed 😄.

@JimMadge
Copy link
Member Author

Probably xfce-screensaver, you can trigger the lockscreen with xfce-screensave-command --lock.

@jemrobinson
Copy link
Member

Happy for you to either uninstall it (although I guess this might break a meta-package) or to disable it similarly to light-locker.

@JimMadge
Copy link
Member Author

Trying that package in #2128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants