Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security checklist #2141

Merged
merged 42 commits into from
Aug 20, 2024
Merged

Add security checklist #2141

merged 42 commits into from
Aug 20, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Aug 19, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

🔬 Tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@JimMadge JimMadge force-pushed the security_checklist branch from b68be1b to 74a0eb6 Compare August 20, 2024 10:45
@JimMadge JimMadge force-pushed the security_checklist branch from a83b5ba to 305a6c7 Compare August 20, 2024 12:52
@JimMadge JimMadge marked this pull request as ready for review August 20, 2024 13:14
@JimMadge JimMadge requested a review from a team as a code owner August 20, 2024 13:14
@JimMadge JimMadge requested review from craddm and jemrobinson August 20, 2024 14:49
craddm
craddm requested changes Aug 20, 2024
View reviewed changes
docs/source/deployment/security_checklist.md Outdated Show resolved Hide resolved
docs/source/deployment/security_checklist.md Outdated Show resolved Hide resolved
docs/source/deployment/security_checklist.md Outdated Show resolved Hide resolved
docs/source/deployment/security_checklist.md Outdated Show resolved Hide resolved
docs/source/deployment/security_checklist.md Outdated Show resolved Hide resolved
@JimMadge @craddm
Apply suggestions from code review
1c01e66 
Co-authored-by: Matt Craddock <mcraddock@turing.ac.uk>
@JimMadge JimMadge requested a review from craddm August 20, 2024 15:09
@JimMadge JimMadge merged commit f1eeb7f into release-v5.0.0 Aug 20, 2024
9 of 10 checks passed
@JimMadge JimMadge deleted the security_checklist branch August 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm approved these changes

@jemrobinson jemrobinson Awaiting requested review from jemrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimMadge @jemrobinson @craddm