Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guacamole copy/paste configuration #2149

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Aug 20, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

🔬 Tests

Tested on a fresh deployment. Unable to copy/paste to/from local machine and workspace.

@JimMadge JimMadge added this to the Release 5.0.0 milestone Aug 20, 2024
@JimMadge JimMadge requested review from a team as code owners August 20, 2024 14:03
@JimMadge JimMadge changed the base branch from develop to release-v5.0.0 August 20, 2024 14:04
Copy link

github-actions bot commented Aug 20, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/external/interface
  azure_postgresql_database.py 145-146
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the connection settings in guacamole now show appropriate configuration:

image

Testing shows that the user can be no longer copy or paste into or out of the workspace, but can copy and paste within it (e.g. from one terminal window to another)

@JimMadge JimMadge merged commit d8aaa84 into release-v5.0.0 Aug 20, 2024
11 checks passed
@JimMadge JimMadge deleted the copy_paste_string branch August 20, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants