Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log messages for SRE deployment #2204

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add log messages for SRE deployment #2204

merged 1 commit into from
Sep 26, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

Closes #2200

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner September 25, 2024 12:11
@JimMadge
Copy link
Member Author

Screenshot 2024-09-25 at 13 12 55

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/commands
  sre.py
Project Total  

This report was generated by python-coverage-comment-action

craddm
craddm approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 4699f05 into develop Sep 26, 2024
11 checks passed
@JimMadge JimMadge deleted the subscription_feedback branch September 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve feedback for subscriptions being used
2 participants
@JimMadge @craddm