Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internet #2233

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Add internet #2233

merged 8 commits into from
Oct 16, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Oct 10, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Adds the option to use 'internet' (case insensitive) in place of IP addresses in configuration.

🌂 Related issues

Closes #2229

🔬 Tests

Tested on a fresh deployment.
Writing the service tag works and I confirmed I can connect from a few different IP addresses

Copy link

github-actions bot commented Oct 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/config
  config_sections.py
  data_safe_haven/infrastructure/programs/sre
  networking.py 71-76
  data_safe_haven/types
  enums.py
  data_safe_haven/validators
  validators.py
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge
Copy link
Member Author

This won't work without some changes.

source_address_prefix can accept tags, but source_address_prefixes cannot.

@JimMadge JimMadge marked this pull request as ready for review October 15, 2024 08:33
@JimMadge JimMadge requested a review from a team as a code owner October 15, 2024 08:33
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 727f43d into develop Oct 16, 2024
11 checks passed
@JimMadge JimMadge deleted the internet branch October 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Internet" as a valid IP address in the config file
2 participants