Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code for checking config availability and SRE deployment status #2234

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Oct 11, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Simplifies the code for checking which configs are available on the SHM and which SREs are deployed. No longer needs to load each stack, and thus is much faster.

🌂 Related issues

🔬 Tests

Tested locally

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  config.py
Project Total  

This report was generated by python-coverage-comment-action

@craddm craddm marked this pull request as ready for review October 11, 2024 10:40
@craddm craddm requested a review from a team as a code owner October 11, 2024 10:40
@craddm craddm requested a review from a team as a code owner October 11, 2024 12:35
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, good use of the Pulumi SDK to avoid reinventing the wheel.

@craddm craddm merged commit ea23e1b into alan-turing-institute:develop Oct 15, 2024
11 checks passed
@craddm craddm deleted the simplify-available branch October 21, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants