Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise subscription logging #2255

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Oct 23, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Replace:

SRE will be deployed to subscription 'My SRE Subscription' ('1e4924cb-a6ae-4193-a847-62f762c6295e')
SRE will be registered in SHM 'myshm.tre.com'
SHM subscription 'dab6dd05-b468-43f2-b629-f669f19714ba'

with

SRE will be deployed to subscription 'My SRE Subscription' (1e4924cb-a6ae-4193-a847-62f762c6295e)
SRE will be registered in SHM 'myshm.tre.com'
SHM is deployed to subscription 'My SHM Subscription' (dab6dd05-b468-43f2-b629-f669f19714ba)

which matches how we log subscriptions elsewhere.

🌂 Related issues

🔬 Tests

@jemrobinson jemrobinson requested a review from a team as a code owner October 23, 2024 14:23
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can get that in for the release if you can fix the tests 👍.

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  sre.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson merged commit fa7122e into release-v5.0.1rc1 Oct 23, 2024
11 checks passed
@jemrobinson jemrobinson deleted the minor-logging-update branch October 23, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants