Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add downloadable template security checklist #2328

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Dec 3, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

Adds a downloadable blank template security checklist in Markdown format, linked on the Security Checklist page

🌂 Related issues

🔬 Tests

Documentation only

craddm and others added 24 commits November 14, 2024 15:38
Co-authored-by: Jim Madge <jim+github@jmadge.com>
…ute/update_tiers

Correct T2/3 PyPI/CRAN proxy information
…hing

Check that a user belongs to the correct SHM domain when registering with an SRE
Copy link

github-actions bot commented Dec 3, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  users.py 167, 172, 277
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge
Copy link
Member

JimMadge commented Dec 3, 2024

😱 I've put some similar changes in on the release branch.

Happy to merge these if there are any differences.

@craddm craddm marked this pull request as ready for review December 3, 2024 14:09
@craddm craddm requested a review from a team as a code owner December 3, 2024 14:09
@craddm craddm changed the base branch from develop to release-v5.2.0 December 3, 2024 14:32
@craddm craddm requested a review from a team as a code owner December 3, 2024 14:32
@JimMadge JimMadge merged commit 8ab3117 into alan-turing-institute:release-v5.2.0 Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants