Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.3.1 #2384

Merged
merged 16 commits into from
Jan 28, 2025
Merged

Release v5.3.1 #2384

merged 16 commits into from
Jan 28, 2025

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Jan 27, 2025 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

🌂 Related issues

Closes #2383

🔬 Tests

jemrobinson and others added 11 commits January 24, 2025 13:45
@jemrobinson
🐛 Store certificate expiry date and mark for renewal if there are few…
11e9d36 
…er than 30 days of validity remaining
@jemrobinson
🎨 Use certificate expiry date rather than trying to guess
66738c9
@jemrobinson
🐛 Use non-versioned secret ID for application gateway
a01221e
@jemrobinson
🐛 Set a maximum number of times to poll for a deleted certificate to …
5a05abe 
…catch the case where a non-existent certificate is being purged
@jemrobinson
📝 Minor phrasing update
7732e2b
@jemrobinson
🥅 Catch specific exceptions rather than general in SSLCertificateProv…
d6546ae 
…ider::create
@jemrobinson
🥅 Catch specific exceptions rather than general in SSLCertificateProv…
57805ac 
…ider::delete
@jemrobinson
🚨 Fix timezone import in SSLCertificateProvider::diff
b12dc8c
@jemrobinson
🥅 Simplify SSLCertificateProvider::refresh
a9f8f11
@jemrobinson @JimMadge
📝 Update suggested pipx version
9b4dc9e 
Co-authored-by: Jim Madge <jim+github@jmadge.com>
@jemrobinson
Merge pull request #2380 from jemrobinson/2361-renew-ssl-cert
e64afdb 
Hotfix: renew SSL certificate in Pulumi
@jemrobinson jemrobinson requested review from a team as code owners January 27, 2025 14:18
JimMadge
JimMadge previously approved these changes Jan 27, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven
  version.py
  data_safe_haven/external/api
  azure_sdk.py 831, 1100
  data_safe_haven/infrastructure/components/dynamic
  ssl_certificate.py 66, 101, 124-126, 159, 174-179, 188-198
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson requested a review from JimMadge January 27, 2025 14:29
@craddm craddm self-requested a review January 28, 2025 09:59
craddm
craddm previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson
Copy link
Member Author

jemrobinson commented Jan 28, 2025 •
edited
Loading

Holding off on merging this until I can confirm that in-place upgrade from 5.3.0 to 5.3.1 works as expected.

Confirmed that this works. Merging with approval from @craddm and @JimMadge .

@jemrobinson jemrobinson merged commit 4a237a9 into latest Jan 28, 2025
11 checks passed
@jemrobinson jemrobinson deleted the release-v5.3.1 branch January 28, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm left review comments

@JimMadge JimMadge Awaiting requested review from JimMadge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jemrobinson @craddm @JimMadge