Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure only files ending with pyc are excluded from desired state uploads #2396

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Feb 6, 2025

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Change the method of excluding .pyc files from upload. Now gets a list of all files and filters them afterwards, rather than trying to filter using rglob.

🌂 Related issues

Closes #2395

🔬 Tests

Tested with a newly deployed VM

Copy link

github-actions bot commented Feb 6, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 👍.

I thought I was being clever using a glob. This is probably slower but it is a lot more readable (and correct!).

By the way, the bug is in develop right? If the bug is in latest this should be a patch release.

@craddm craddm marked this pull request as ready for review February 7, 2025 11:17
@craddm craddm requested a review from a team as a code owner February 7, 2025 11:17
@craddm craddm merged commit 87d6a5b into alan-turing-institute:develop Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some desired state files not uploaded to desired state container
2 participants