Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version in tests (plus additional minor fixes) #116

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

davidwilby
Copy link
Collaborator

@davidwilby davidwilby commented Jun 13, 2024

Whilst looking into #115 I noticed that something funky was going in the CI environment when running tests in which a different python version from the ones specified in the version matrix, using python 3.10 for all of the tests.

This turned out to be because of the step in which space was being cleared, inadvertently deleting the python executable installed by the setup-python action at /opt/hostedtoolscache. I've replaced this with a different option using the jlumbroso/free-disk-space action for ubuntu runners. Have tested this out over on my fork and confirmed that the expected python versions are being used in running tests by tox.

Additionally, this PR:

  • upgrades some deprecated actions versions,
  • Fixes a bug found when running tests with python 3.8 in which the post-3.8 typehint style was being used, resulting in an error. I suggest this fix rather than shifting to the newer style since python 3.8 is still technically in support for the time-being. (Edit: https://pypi.org/project/typing-extensions/ would be another option for this, but maybe in a separate PR)

@tom-andersson
Copy link
Collaborator

Great catches @davidwilby. Fairly shallow review but passes a sanity check of what you've described. LGTM (and sorry for the delay).

@tom-andersson tom-andersson merged commit 02cbcb8 into main Jul 7, 2024
6 of 10 checks passed
@tom-andersson
Copy link
Collaborator

@all-contributors please add @davidwilby for maintenance

Copy link
Contributor

@tom-andersson

I've put up a pull request to add @davidwilby! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants