Skip to content

Commit

Permalink
Release 0.7.4
Browse files Browse the repository at this point in the history
  • Loading branch information
alanconway committed Nov 12, 2024
1 parent 5efb889 commit 82d68f6
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 5 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

_Note unreleased changes here_

## [0.7.4] - 2024-11-12

### Added
- Adjust log verbose level via API at runtime.
- Added "ndjson" output type

### Fixed
- Trace domain fixes: OTEL rules, tempo select clauses and constraints, handle missing attributes.

## [0.7.3] - 2024-11-01

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ help: ## Display this help.
@grep -E '^## [A-Z0-9_]+: ' Makefile | sed 's/^## \([A-Z0-9_]*\): \(.*\)/\1#\2/' | column -s'#' -t

## VERSION: Semantic version for release, use -dev for development pre-release versions.
VERSION?=0.7.4-dev
VERSION?=0.7.4
## REGISTRY_BASE: Image registry base, for example quay.io/somebody
REGISTRY_BASE?=$(error REGISTRY_BASE must be set to push images)
## IMGTOOL: May be podman or docker.
Expand Down
2 changes: 1 addition & 1 deletion config/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ labels:
images:
- name: quay.io/korrel8r/korrel8r
newName: quay.io/korrel8r/korrel8r
newTag: 0.7.3
newTag: 0.7.4
2 changes: 1 addition & 1 deletion internal/pkg/build/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.7.4-dev
0.7.4
3 changes: 1 addition & 2 deletions pkg/domains/trace/tempo.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ func defaultSelect(traceQL string) string {
func formatTime(t time.Time) string { return strconv.FormatInt(t.UTC().Unix(), 10) }

func (c *client) get(ctx context.Context, traceQL string, constraint *korrel8r.Constraint, collect func(*Span)) error {
// FIXME constraint
u := *c.base // Copy, don't modify base.
v := url.Values{query: []string{defaultSelect(traceQL)}}
if limit := constraint.GetLimit(); limit > 0 {
Expand Down Expand Up @@ -148,7 +147,7 @@ func (tt *tempoTrace) collect(spans tempoSpanSet, collect func(*Span)) {
Status: Status{Code: StatusUnset}, // Default
}
span.Attributes = ts.Attributes.Map()
span.Attributes[otel.AttrServiceName] = tt.RootServiceName // FIXME
span.Attributes[otel.AttrServiceName] = tt.RootServiceName
// Tempo HTTP API stores span status description as "status" attribute.
// Move it to the status field and deduce the status code.
span.Status.Description, _ = span.Attributes[statusAttr].(string)
Expand Down

0 comments on commit 82d68f6

Please sign in to comment.