Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake options missing project specific prefix #315

Closed
1 of 4 tasks
globberwops opened this issue Dec 23, 2022 · 1 comment · Fixed by #316
Closed
1 of 4 tasks

CMake options missing project specific prefix #315

globberwops opened this issue Dec 23, 2022 · 1 comment · Fixed by #316
Labels
enhancement - build system Improvements or additions to build system

Comments

@globberwops
Copy link
Contributor

Feature category

  • enhancement - backends
  • enhancement - build system
  • enhancement - documentation
  • enhancement - plot categories

The problem

CMake options do not have a project specific prefix and may hence interact/interfere with the cache variables of a parent project.

The solution I'd like
Prefix CMake options with the project name.
This will not only fix the above problem, but will also nicely cluster the variables in the CMake cache and the CMake GUI.

Alternatives I've considered
None.
@github-actions github-actions bot added the enhancement - build system Improvements or additions to build system label Dec 23, 2022
@globberwops globberwops mentioned this issue Dec 23, 2022
Merged
@alandefreitas
Copy link
Owner

Yes. Namespacing these options would be great. It has caused me a few problems in past as well.

alandefreitas pushed a commit that referenced this issue Jan 19, 2023
@globberwops
CMake options have project prefix
5b348ba 
fix #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement - build system Improvements or additions to build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake options missing project specific prefix
2 participants
@alandefreitas @globberwops