Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Commit

Permalink
disable TURN on blocked ports
Browse files Browse the repository at this point in the history
  • Loading branch information
alangecker committed Mar 28, 2021
1 parent d43a2f3 commit e0986a5
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 9 deletions.
3 changes: 0 additions & 3 deletions sample.env
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
# fully automated Lets Encrypt certificates
ENABLE_HTTPS_PROXY=true

# coturn (a TURN Server)
# requires HTTPS Proxy to be enabled
ENABLE_COTURN=true

# Greenlight Frontend
# https://docs.bigbluebutton.org/greenlight/gl-overview.html
Expand Down
24 changes: 24 additions & 0 deletions scripts/compose
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,30 @@ if [ -z "$EXTERNAL_IPv4" ]; then
exit 1
fi

# check for blocked TURN port
# https://github.com/bigbluebutton/docker/issues/73
if [ -n "$TURN_SERVER" ]; then
port=$(echo $TURN_SERVER | awk -F: '{print $3}' | awk -F'?' '{print $1}')
if [[ "$port" -lt "1024" ]] && [ "$port" != "443" ] && [ "$port" != "80" ]; then
echo "-------------------------------------"
echo "ERROR: you use the TURN port $port, which gets blocked by recent browser"
echo "releases, leading BBB throwing always an 1006 error, connecting impossible."
echo ""
echo "If you use the integrated TURN server, there is currently no way to make it"
echo "work. so you should disable the server by emptying the TURN_SERVER variable"
echo "in .env"
echo "If you use an external TURN server with an own IP, you should switch to"
echo "port 443"
echo ""
echo "More Information: https://github.com/bigbluebutton/docker/issues/73"
echo
echo "current setting:"
echo "TURN_SERVER=$TURN_SERVER"
echo "-------------------------------------"
exit 1
fi
fi

# set conditional variables
export CERTIFICATE_DOMAINS=$DOMAIN
export GREENLIGHT_ENDPOINT=https://$DOMAIN/bigbluebutton/api/
Expand Down
14 changes: 8 additions & 6 deletions scripts/setup
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ while [[ ! $https_proxy =~ ^(y|n)$ ]]; do
done

coturn=""
if [ "$https_proxy" == "y" ]
then
while [[ ! $coturn =~ ^(y|n)$ ]]; do
read -p "Should a coturn be included? (y/n): " coturn
done
fi
# comment out due to blocked TURN ports
# https://github.com/bigbluebutton/docker/issues/73
# if [ "$https_proxy" == "y" ]
# then
# while [[ ! $coturn =~ ^(y|n)$ ]]; do
# read -p "Should a coturn be included? (y/n): " coturn
# done
# fi

prometheus_exporter=""
while [[ ! $prometheus_exporter =~ ^(y|n)$ ]]; do
Expand Down

0 comments on commit e0986a5

Please sign in to comment.