Support TS type argument syntax in optional chaining #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward #461 The previous implemented worked for normal JS syntax, but `f?.<T>()` needs a special case when working with tokens. Also, regular type argument syntax wasn't marking the open-paren correctly, so this fixes that as well.
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 82.56% 82.59% +0.02%
==========================================
Files 54 54
Lines 5536 5545 +9
Branches 1236 1238 +2
==========================================
+ Hits 4571 4580 +9
Misses 678 678
Partials 287 287
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #461
The previous implemented worked for normal JS syntax, but
f?.<T>()needs aspecial case when working with tokens. Also, regular type argument syntax wasn't
marking the open-paren correctly, so this fixes that as well.