Attempt to make fill and colour match

alanocallaghan · Jun 4, 2024 · 2d5b60a · 2d5b60a
1 parent 6d4ab43
commit 2d5b60a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/plot_central.R b/R/plot_central.R
@@ -248,9 +248,10 @@ NULL
                 colour_by <- paste0(summary_fun, "(", colour_by, ")")
             }
         }
+        browser()
         plot_out <- .resolve_plot_colours(
-            plot_out, object$colour_by, colour_by, fill = point_out$fill,
-            colour = !point_out$fill, do_bin = !is.null(bins)
+            plot_out, object$colour_by, colour_by, fill = !is.null(fill_by),
+            colour = !is.null(colour_by), do_bin = !is.null(bins)
         )
     }
 

diff --git a/R/plot_colours.R b/R/plot_colours.R
@@ -45,7 +45,6 @@
     }
     # Picking whether to fill or not.
     aesthetics <- c("fill", "colour")[c(fill, colour)]
-
     if (fill) {
         VIRIDFUN <- scale_fill_viridis
         SCALEFUN <- scale_fill_manual