Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Export all TS types #6

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Conversation

danilofuchs
Copy link
Contributor

@danilofuchs danilofuchs commented Jan 18, 2021

  • Export all types from /typings/index.ts file
    This allows consumers to declare configs in their own code without needing to use import { RedactItConfig } from "redact-it/dist/typings"

  • Remove complementary for non-center positions, as it is undocumented and confusing

  • Improve JSDocs on types

  • Rename RedacItConfig to RedactItConfig (typo)

  • Add test to ensure rules can be overriden

@@ -1 +1,2 @@
export { redactIt } from "./src/redact-it";
export * from "./typings";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

Copy link
Owner

@alanpcs alanpcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the great contributions 🎉
I left some comments there but the enhancements in usability seems really nice.

typings/index.ts Show resolved Hide resolved
typings/index.ts Show resolved Hide resolved
Co-authored-by: Alan P. C. Silva <7315217+alanpcs@users.noreply.github.com>
@alanpcs alanpcs merged commit 2d5f82b into alanpcs:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants