Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to work with public organization repos. #175

Closed
ssmereka opened this issue Feb 6, 2015 · 7 comments · Fixed by #189
Closed

Does not seem to work with public organization repos. #175

ssmereka opened this issue Feb 6, 2015 · 7 comments · Fixed by #189

Comments

@ssmereka
Copy link

ssmereka commented Feb 6, 2015

No repositories are listed when accessing an organization's repositories.

Example: https://david-dm.org/smartdevicelink

@mauvm
Copy link

mauvm commented Mar 18, 2015

Having the same issue.

@saibotsivad
Copy link

This issue still exists.

@saibotsivad
Copy link

Without having tried to run it locally, it looks like the issue is on https://github.com/alanshaw/david-www/blob/master/lib/profile.js#L30

The Github API says "get users repos" is different than "get orgs repos", so the github module has a different call for getTeamRepos.

@htanjo
Copy link
Contributor

htanjo commented May 14, 2015

I found this could fixed removing type: "all" in profile.js#L30.

@saibotsivad,
Yes, GitHub has different API for organization, but repos#getFromUser can also return org repos. For example: https://api.github.com/users/github/repos
-> This returns "github organization" repos.

@alanshaw,
I'm not sure it works perfectly or not without type option because I can't test private repos.
Do you have any concern? I'm planning to send a PR.

@alanshaw
Copy link
Owner

Hey, thanks, please send a PR and I'll double check :)

@saibotsivad
Copy link

I booted up david-www and checked that patch and it works great. Thanks, @htanjo!

@htanjo
Copy link
Contributor

htanjo commented May 15, 2015

No problem! Glad to solve this. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants