Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(highlight): link to treesitter highlight groups instead of vim ones since themes revolve around them #56

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

aMOPel
Copy link
Contributor

@aMOPel aMOPel commented Oct 21, 2023

:h treesitter-highlight-groups

All @<group> tree sitter highlights are linked to classic vim highlights, so nothing is really lost here, if a theme doesn't use @<group> highlights, but this increases compatibility with modern themes which use @<group> highlights.

Also this enables the use of nimsuggest's semantic highlights with treesitter highlights. Otherwise the colors will clash.

@aMOPel
Copy link
Contributor Author

aMOPel commented Oct 21, 2023

I added a version check as well now.

You might wanna double check if I found the correct version.

I looked at the git blame
where the default links were added and then looked at what version that commit was added
which seemed to be v0.9.0.
At least that's when all of them were done.

Copy link
Owner

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaviss alaviss merged commit 076239e into alaviss:master Oct 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants