Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"interval_tree" instead of "segment_tree" #11

Merged
merged 3 commits into from
Apr 12, 2019
Merged

"interval_tree" instead of "segment_tree" #11

merged 3 commits into from
Apr 12, 2019

Conversation

alaz
Copy link
Owner

@alaz alaz commented Apr 11, 2019

No description provided.

@alaz
Copy link
Owner Author

alaz commented Apr 11, 2019

@kirichkov could you please review. Are there any other test cases you would like to cover?

kirichkov
kirichkov approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@kirichkov kirichkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Looks great! I'll put it into action and take it from there if new issues arise! Thank you!!!

@alaz
Copy link
Owner Author

alaz commented Apr 12, 2019

Do you want me to release?

@kirichkov
Copy link
Contributor

Do you want me to release?

Yes, please. Unless you want me to point at that branch and drop it into production and see how it works in the real world :-)

@alaz
Copy link
Owner Author

alaz commented Apr 12, 2019

OK, I am releasing then.

@alaz alaz merged commit eb2d53c into master Apr 12, 2019
@kirichkov
Copy link
Contributor

So far so good. No false positives!

@alaz
Copy link
Owner Author

alaz commented Apr 13, 2019

Great! 👍

@alaz alaz deleted the interval-tree branch April 14, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirichkov kirichkov kirichkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaz @kirichkov