Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jetbrains_projects] Fix Rider config #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[jetbrains_projects] Fix Rider config #207

wants to merge 1 commit into from

Conversation

albi005
Copy link

@albi005 albi005 commented Nov 12, 2024 •
edited
Loading

tomsquest
tomsquest approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@tomsquest tomsquest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah Jetbrains... :/

I would have skipped is_rider and detect it inline in the Editor class, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsquest tomsquest tomsquest approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jetbrains_projects] Wrong configuration for Rider
2 participants
@albi005 @tomsquest