Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the problem with themes like Sweet-Dark-v40 #17

Closed
wants to merge 1 commit into from

Conversation

HetDaftary
Copy link

The original code needs the theme name to end with '-dark' and all dark theme names do not end with '-dark'.
For example, Matcha-dark-sea or Sweet-Dark-v40 create a problem with the original code has the code detects them as light theme and not dark theme.
I have fixed this by finding 'dark' in the theme after converting the theme name to lower case.

@albertosottile
Copy link
Owner

Hi, thanks for this contribution.

I am fine with this, but I also hope this would not cause wrong detections in the other direction. Having to rely solely on having "dark" in the theme name seems a little feeble, if you ask me. At least the suffix -dark was a little more specific.

Is there a place where all these theme names are listed?

@DoctorDalek1963
Copy link
Contributor

I've updated this PR in #24, where I add the same fix to the listener() function. I would suggest rejecting this one and merging that one instead.

@albertosottile
Copy link
Owner

I am closing this since it was superseded by #24. @HetDaftary I hope the merged outcome is acceptable for you and I apologize that your PR was, in the end, discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants