Upload test report #134
Open
Upload test report #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 25, 2023 10:44
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
added 3 commits
December 25, 2023 22:38
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Unit Tests Summary0 tests 0 ✅ 0s ⏱️ Results for commit 7abd754. ♻️ This comment has been updated with latest results. |
This reverts commit 7a4d186.
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? - part of jaegertracing#5006 ## Description of the changes - fix goroutine leaks in some package and add goleak check ## How was this change tested? - go test --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? - It was no longer possible to run `make proto` on Macs with Apple silicon since the Docker image with protobuf was only built for amd64. - We are generating unoptimized protobuf types for OTLP without Gogo, which will be a problem for jaeger-v2 ## Description of the changes - Upgrade jaegertracing/protobuf to https://github.com/jaegertracing/docker-protobuf/releases/tag/v0.5.0 - Move proto/thrift/crossdock-related targets into separate files `Makefile.*.mk` - Proto targets improvements - DRY targets by using a macro for invoking protoc - Separate different modules into different targets - Add some pretty logging ## How was this change tested? - `make proto` regenerates all the files without any additional changes ## Next steps - [ ] `proto-hotrod` produces a different file now, need to regenerate and test with HotROD, and then include it into the main `make proto` target - [ ] Thrift gen produces a different output (can't run it on Mac) - [ ] Utilize sed script from OTEL to add Gogo annotations to OTLP protos, to generate more efficient representation --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
…aegertracing#5036) Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? - Resolves jaegertracing#5043 ## Description of the changes - `go-junit-report` was getting installed successfully into the default `$GOPATH` (`$HOME/go/bin`) but the GOPATH wasn't in the `$PATH` environment variable, which is what caused the `go-junit-report: command not found` error. - It worked for the normal (non-go-tip) unit tests because the `$GOPATH` was already set and inserted into `$PATH`. - This explicitly sets the `$GOPATH` and inserts it into `$PATH` prior to installing test tools. ## How was this change tested? - Tested in [my own fork](https://github.com/albertteoh/jaeger/actions/runs/7332463204/job/19966641893) with some debug logging in the Makefile. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits --------- Signed-off-by: Albert Teoh <albert@packsmith.io> Co-authored-by: Albert Teoh <albert@packsmith.io>
…aegertracing#5045) ## Which problem is this PR solving? - Remove duplicated code for handling Zipkin formats that requires a dependency on open-api packages - This will also help with jaeger-v2 since we'll just reuse the same OTEL Zipkin receiver, no more breaking changes ## Description of the changes - Swap custom Zipkin server for Zipkin Receiver from OTel Collector Contrib - (**breaking** 🛑) Zipkin Proto receiver requires 128bit trace ID, otherwise `TraceID: has length 8 yet wanted length 16`. Jaeger receiver did not have such limitation. - (**breaking** 🛑) the `--collector.zipkin.keep-alive` setting is not supported in the OTEL receiver - Delete a bunch of packages and files that are no longer needed (5k lines, including code-gen) - `go mod tidy` removed all `go-openapi` dependencies and a few others ## How was this change tested? - Added unit tests `cmd/collector/app/handler/zipkin_receiver_test.go` that submit various Zipkin formats to the receiver - Crossdock tests also cover similar exports in CI: ``` Executing Matrix... ✓ [endtoend] test_driver→ (services=go) ⇒ Pass ✓ [endtoend] test_driver→ (services=java) ⇒ Pass ✓ [endtoend] test_driver→ (services=node) ⇒ Pass ✓ [endtoend] test_driver→ (services=python) ⇒ Pass ✓ [endtoend] test_driver→ (services=zipkin-brave-json) ⇒ Pass ✓ [endtoend] test_driver→ (services=zipkin-brave-json-v2) ⇒ Pass ✓ [endtoend] test_driver→ (services=zipkin-brave-proto) ⇒ Pass ✓ [endtoend] test_driver→ (services=zipkin-brave-thrift) ⇒ Pass ``` ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
…aegertracing#5049) Bumps [crazy-max/ghaction-import-gpg](https://github.com/crazy-max/ghaction-import-gpg) from 6.0.0 to 6.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/crazy-max/ghaction-import-gpg/releases">crazy-max/ghaction-import-gpg's releases</a>.</em></p> <blockquote> <h2>v6.1.0</h2> <ul> <li>Bump <code>@actions/core</code> from 1.10.0 to 1.10.1 in <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/pull/186">crazy-max/ghaction-import-gpg#186</a></li> <li>Bump <code>@babel/traverse</code> from 7.17.3 to 7.23.2 in <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/pull/191">crazy-max/ghaction-import-gpg#191</a></li> <li>Bump debug from 4.1.1 to 4.3.4 in <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/pull/190">crazy-max/ghaction-import-gpg#190</a></li> <li>Bump openpgp from 5.10.1 to 5.11.0 in <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/pull/192">crazy-max/ghaction-import-gpg#192</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/crazy-max/ghaction-import-gpg/compare/v6.0.0...v6.1.0">https://github.com/crazy-max/ghaction-import-gpg/compare/v6.0.0...v6.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/01dd5d3ca463c7f10f7f4f7b4f177225ac661ee4"><code>01dd5d3</code></a> Merge pull request <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/issues/186">#186</a> from crazy-max/dependabot/npm_and_yarn/actions/core-1...</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/ab787acd76df439754c9d4495474a162ecdbd52b"><code>ab787ac</code></a> chore: update generated content</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/c63a0195c8eb738ea912dcf5f995cba7ef6a969d"><code>c63a019</code></a> build(deps): bump <code>@actions/core</code> from 1.10.0 to 1.10.1</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/81f63a86f464ab4d0bd85d3eb2099af40a1c7d37"><code>81f63a8</code></a> Merge pull request <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/issues/191">#191</a> from crazy-max/dependabot/npm_and_yarn/babel/traverse...</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/98ff7fb2c6a551a641d84f9c9628510300456b49"><code>98ff7fb</code></a> Merge pull request <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/issues/190">#190</a> from crazy-max/dependabot/npm_and_yarn/debug-4.3.4</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/e83a2eaa2fe8ab264225336863cea22ba4f6b500"><code>e83a2ea</code></a> Merge pull request <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/issues/193">#193</a> from crazy-max/dependabot/github_actions/actions/gith...</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/2e40814c3126af71bf5693b6944e689b9bf1b9bd"><code>2e40814</code></a> Merge pull request <a href="https://redirect.github.com/crazy-max/ghaction-import-gpg/issues/192">#192</a> from crazy-max/dependabot/npm_and_yarn/openpgp-5.11.0</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/480319b8ff2b7c6e97aa00ece262a52f2832c5b0"><code>480319b</code></a> chore: update generated content</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/019a31d4762d514ed1ccc97d0194ad7d3a5f9464"><code>019a31d</code></a> build(deps): bump actions/github-script from 6 to 7</li> <li><a href="https://github.com/crazy-max/ghaction-import-gpg/commit/24f4ba9d1ec3d7d7e2f2079f38d858fe89987b68"><code>24f4ba9</code></a> build(deps): bump openpgp from 5.10.1 to 5.11.0</li> <li>Additional commits viewable in <a href="https://github.com/crazy-max/ghaction-import-gpg/compare/82a020f1f7f605c65dd2449b392a52c3fcfef7ef...01dd5d3ca463c7f10f7f4f7b4f177225ac661ee4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## Which problem is this PR solving? - Part of jaegertracing#5052 - Continuation of jaegertracing#5046 ## Description of the changes - Add tests for all HTTP APIs, not just GetTrace - Use snapshots to make validation of HTTP/JSON response from the server easier - Replace grpc-gateway/runtime JSONPb marshaler (in tests) with gogo/jsonpb marshaler ## Gaps - The error conditions are not being tested currently, such as not specifying the timestamps in the query ## How was this change tested? - Unit tests --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? - Part of jaegertracing#5052 ## Description of the changes - Pull in IDL change jaegertracing/jaeger-idl#102 - Re-implement APIv3 HTTP endpoints without the use of grpc-gateway - Share tests from grpc-gateway for manual implementation - Refactor tests to avoid duplication of snapshots - Fix inconsistency between http and grpc tenancy interceptors where HTTP was returning Unauthenticated in certain cases, but GRPC was always returning Forbidden. Make them consistent: missing tenant header results in Unauthenticated. ## Follow-ups - [x] http implementation needs more unit tests (mostly error handling and parameter variations) - [ ] the new implementation is not hooked up into production code yet, I first want to confirm it works with model-v2, and just in general minimize the scope of a single PR ## How was this change tested? - Using unit tests added in jaegertracing#5051, with additional enhancements --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? - Part of jaegertracing#5052 - Continues jaegertracing#5054 - Closes jaegertracing#4911 ## Description of the changes - Replace grpc-gateway based implementation with manual HTTP implementation from jaegertracing#5054 - Clean up spurious grpc-gateway usage (e.g. all-in-one test that did not need it) - Delete grpc-gateway step from `make proto` and remove the corresponding generated file - `go mod tidy` removes grpc-gateway and github.com/golang/protobuf ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
## Which problem is this PR solving? - fix gorourine leak in some packages ## Description of the changes - part of jaegertracing#5006 ## How was this change tested? - go test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` --------- Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Test Results2 052 tests - 10 2 042 ✅ - 10 1m 9s ⏱️ -3s Results for commit 36a32c9. ± Comparison against base commit 69e2408. This pull request removes 66 and adds 56 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
added 2 commits
January 1, 2024 18:15
Signed-off-by: Albert Teoh <albert@packsmith.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing